[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/da7219: Allow disabling micbias-pulse feature

Akshu Agrawal (Code Review) gerrit at coreboot.org
Thu Jul 26 08:43:20 CEST 2018


Akshu Agrawal has posted comments on this change. ( https://review.coreboot.org/27613 )

Change subject: drivers/i2c/da7219: Allow disabling micbias-pulse feature
......................................................................


Patch Set 1: Code-Review+1

Most of the platform do need to give micbias pulse level as it is used to specify higher voltage of 2.8V or 2.9V in MICBIAS_CTRL

Verified it, Not getting "Invalid micbias pulse level" after the patch


-- 
To view, visit https://review.coreboot.org/27613
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9
Gerrit-Change-Number: 27613
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal at amd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 26 Jul 2018 06:43:20 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180726/7e65b1af/attachment.html>


More information about the coreboot-gerrit mailing list