<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/27613">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Akshu Agrawal: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/i2c/da7219: Allow disabling micbias-pulse feature<br><br>These two da7219_aad properties are optional:<br>- dlg,micbias-pulse-lvl : Mic bias higher voltage pulse level (mV).<br>        [<2800>, <2900>]<br>- dlg,micbias-pulse-time : Mic bias higher voltage pulse duration (ms)<br><br>When the Mic Bias Higher Voltage feature is not required, firmware should<br>just not provide the dlg,micbias-pulse-lvl and dlg,micbias-pulse-time<br>properties.<br><br>Signed-off-by: Daniel Kurtz <djkurtz@chromium.org><br><br>BUG=b:111700809<br>TEST=On grunt:<br> No "Invalid micbias pulse level" in dmesg<br><br>Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9<br>Reviewed-on: https://review.coreboot.org/27613<br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>Reviewed-by: Akshu Agrawal <akshu.agrawal@amd.com><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M src/drivers/i2c/da7219/da7219.c<br>1 file changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/i2c/da7219/da7219.c b/src/drivers/i2c/da7219/da7219.c</span><br><span>index b8af689..43e6076 100644</span><br><span>--- a/src/drivers/i2c/da7219/da7219.c</span><br><span>+++ b/src/drivers/i2c/da7219/da7219.c</span><br><span>@@ -77,10 +77,12 @@</span><br><span>         acpi_dp_add_integer(aad, "dlg,c-mic-btn-thr", config->c_mic_btn_thr);</span><br><span>   acpi_dp_add_integer(aad, "dlg,btn-avg", config->btn_avg);</span><br><span>       acpi_dp_add_integer(aad, "dlg,adc-1bit-rpt", config->adc_1bit_rpt);</span><br><span style="color: hsl(0, 100%, 40%);">-        acpi_dp_add_integer(aad, "dlg,micbias-pulse-lvl",</span><br><span style="color: hsl(0, 100%, 40%);">-                         config->micbias_pulse_lvl);</span><br><span style="color: hsl(0, 100%, 40%);">-      acpi_dp_add_integer(aad, "dlg,micbias-pulse-time",</span><br><span style="color: hsl(0, 100%, 40%);">-                        config->micbias_pulse_time);</span><br><span style="color: hsl(120, 100%, 40%);">+   if (config->micbias_pulse_lvl > 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+            acpi_dp_add_integer(aad, "dlg,micbias-pulse-lvl",</span><br><span style="color: hsl(120, 100%, 40%);">+                               config->micbias_pulse_lvl);</span><br><span style="color: hsl(120, 100%, 40%);">+            acpi_dp_add_integer(aad, "dlg,micbias-pulse-time",</span><br><span style="color: hsl(120, 100%, 40%);">+                              config->micbias_pulse_time);</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span> </span><br><span>        /* DA7219 Properties */</span><br><span>      dsd = acpi_dp_new_table("_DSD");</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27613">change 27613</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27613"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9 </div>
<div style="display:none"> Gerrit-Change-Number: 27613 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal@amd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>