[coreboot-gerrit] Change in coreboot[master]: abuild: Update failed boards handling

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/27596


Change subject: abuild: Update failed boards handling
......................................................................

abuild: Update failed boards handling

- Use TARGET variable for location of passing/failing boards files.
This should better handle the directory, wherever it is.
- Don't save make.log location if make.log is being deleted.

Change-Id: I28e55feef85c9b642ac5ff70ecef113cf7978707
Signed-off-by: Martin Roth <gaumless at gmail.com>
---
M util/abuild/abuild
1 file changed, 7 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/27596/1

diff --git a/util/abuild/abuild b/util/abuild/abuild
index 5ec416a..f67117c 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -379,7 +379,11 @@
 		printf "failed\n" > compile.status
 		printf "%s build FAILED after %ss!\nLog excerpt:\n" "$BUILD_NAME" "${duration}"
 		tail -n $CONTEXT make.log 2> /dev/null || tail -$CONTEXT make.log
-		echo "$BUILD_NAME - Log: ${TOP}/${build_dir}/make.log" >> "$FAILED_BOARDS"
+		if [ "$clean_work" = "true" ]; then
+			echo "$BUILD_NAME" >> "$FAILED_BOARDS"
+		else
+			echo "$BUILD_NAME - Log: ${build_dir}/make.log" >> "$FAILED_BOARDS"
+		fi
 		failed=1
 	fi
 	cd "$CURR" || return $?
@@ -740,8 +744,8 @@
 	customizing="default configuration"
 fi
 
-FAILED_BOARDS="${COREBOOT_BUILD_DIR:-${TOP}/coreboot-builds}/failed_boards"
-PASSED_BOARDS="${COREBOOT_BUILD_DIR:-${TOP}/coreboot-builds}/passing_boards"
+FAILED_BOARDS="${TARGET}/failed_boards"
+PASSED_BOARDS="${TARGET}/passing_boards"
 
 if [ "$recursive" = "false" ]; then
 	rm -f "$FAILED_BOARDS" "$PASSED_BOARDS"

-- 
To view, visit https://review.coreboot.org/27596
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28e55feef85c9b642ac5ff70ecef113cf7978707
Gerrit-Change-Number: 27596
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180723/ecab6c84/attachment-0001.html>