<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27596">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abuild: Update failed boards handling<br><br>- Use TARGET variable for location of passing/failing boards files.<br>This should better handle the directory, wherever it is.<br>- Don't save make.log location if make.log is being deleted.<br><br>Change-Id: I28e55feef85c9b642ac5ff70ecef113cf7978707<br>Signed-off-by: Martin Roth <gaumless@gmail.com><br>---<br>M util/abuild/abuild<br>1 file changed, 7 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/27596/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/abuild/abuild b/util/abuild/abuild</span><br><span>index 5ec416a..f67117c 100755</span><br><span>--- a/util/abuild/abuild</span><br><span>+++ b/util/abuild/abuild</span><br><span>@@ -379,7 +379,11 @@</span><br><span>          printf "failed\n" > compile.status</span><br><span>              printf "%s build FAILED after %ss!\nLog excerpt:\n" "$BUILD_NAME" "${duration}"</span><br><span>                tail -n $CONTEXT make.log 2> /dev/null || tail -$CONTEXT make.log</span><br><span style="color: hsl(0, 100%, 40%);">-            echo "$BUILD_NAME - Log: ${TOP}/${build_dir}/make.log" >> "$FAILED_BOARDS"</span><br><span style="color: hsl(120, 100%, 40%);">+          if [ "$clean_work" = "true" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+                       echo "$BUILD_NAME" >> "$FAILED_BOARDS"</span><br><span style="color: hsl(120, 100%, 40%);">+              else</span><br><span style="color: hsl(120, 100%, 40%);">+                  echo "$BUILD_NAME - Log: ${build_dir}/make.log" >> "$FAILED_BOARDS"</span><br><span style="color: hsl(120, 100%, 40%);">+         fi</span><br><span>           failed=1</span><br><span>     fi</span><br><span>   cd "$CURR" || return $?</span><br><span>@@ -740,8 +744,8 @@</span><br><span>      customizing="default configuration"</span><br><span> fi</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-FAILED_BOARDS="${COREBOOT_BUILD_DIR:-${TOP}/coreboot-builds}/failed_boards"</span><br><span style="color: hsl(0, 100%, 40%);">-PASSED_BOARDS="${COREBOOT_BUILD_DIR:-${TOP}/coreboot-builds}/passing_boards"</span><br><span style="color: hsl(120, 100%, 40%);">+FAILED_BOARDS="${TARGET}/failed_boards"</span><br><span style="color: hsl(120, 100%, 40%);">+PASSED_BOARDS="${TARGET}/passing_boards"</span><br><span> </span><br><span> if [ "$recursive" = "false" ]; then</span><br><span>     rm -f "$FAILED_BOARDS" "$PASSED_BOARDS"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27596">change 27596</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27596"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I28e55feef85c9b642ac5ff70ecef113cf7978707 </div>
<div style="display:none"> Gerrit-Change-Number: 27596 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>