[coreboot-gerrit] Change in coreboot[master]: Build system: Add Fixes for scanbuild

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/27595


Change subject: Build system: Add Fixes for scanbuild
......................................................................

Build system: Add Fixes for scanbuild

- Exclude build flags that generate warnings when scanbuild is running
- Add the SCANBUILD_ARGS variable to abuild so we can pass in arguments
to scanbuild.
- Set the default scanbuild argument to -k (--keep-going) so that even
if an error occurs it continues with the scan.  This is similar to what
we do with coverity runs.

Change-Id: I82e7c13d7fd7432b43c17a31834ec82fca158a07
Signed-off-by: Martin Roth <gaumless at gmail.com>
---
M Makefile.inc
M util/abuild/abuild
2 files changed, 5 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/27595/1

diff --git a/Makefile.inc b/Makefile.inc
index 6884a90..db59226 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -385,11 +385,13 @@
 CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer
 CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie
 ifeq ($(CONFIG_COMPILER_GCC),y)
-CFLAGS_common += -Wno-packed-not-aligned
 CFLAGS_common += -fno-delete-null-pointer-checks
 # Don't add these GCC specific flags when running scan-build
 ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),)
+CFLAGS_common += -Wno-packed-not-aligned
 CFLAGS_common += -fconserve-stack
+# cf. commit f69a99db (coreboot: x86: enable gc-sections)
+CGLAGS_common += -Wno-unused-but-set-variable
 endif
 endif
 
@@ -439,11 +441,6 @@
 
 LDFLAGS_common := --gc-sections -nostdlib -nostartfiles -static --emit-relocs
 
-ifeq ($(CONFIG_COMPILER_GCC),y)
-# cf. commit f69a99db (coreboot: x86: enable gc-sections)
-CFLAGS_common += -Wno-unused-but-set-variable
-endif
-
 ifeq ($(CONFIG_WARNINGS_ARE_ERRORS),y)
 CFLAGS_common += -Werror
 endif
diff --git a/util/abuild/abuild b/util/abuild/abuild
index 85881b3..5ec416a 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -469,7 +469,7 @@
 		if [ "$scanbuild" = "true" ]; then
 			scanbuild_out=$TARGET/${BUILD_NAME}-scanbuild
 			rm -rf "${scanbuild_out}"
-			BUILDPREFIX="scan-build -o ${scanbuild_out}tmp"
+			BUILDPREFIX="scan-build ${SCANBUILD_ARGS} -o ${scanbuild_out}tmp"
 		fi
 		compile_target "${BUILD_NAME}"
 		if [ "$scanbuild" = "true" ]; then
@@ -667,6 +667,7 @@
 		--scan-build)   shift
 			scanbuild=true
 			customizing="${customizing}, scan-build"
+			SCANBUILD_ARGS=${SCANBUILD_ARGS:-'-k'}
 			;;
 		-y|--ccache)    shift
 			customizing="${customizing}, ccache"

-- 
To view, visit https://review.coreboot.org/27595
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82e7c13d7fd7432b43c17a31834ec82fca158a07
Gerrit-Change-Number: 27595
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180723/627ee28d/attachment-0001.html>