[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: Add internal pull-up for USB2_OC2#

[Seunghwan Kim (Code Review)]

Seunghwan Kim has uploaded this change for review. ( https://review.coreboot.org/27542


Change subject: mb/google/poppy/variants/nautilus: Add internal pull-up for USB2_OC2#
......................................................................

mb/google/poppy/variants/nautilus: Add internal pull-up for USB2_OC2#

Nautilus-WiFi board doesn't have external pull-up on USB2_OC2# route, then
abnormal over-current is asserted on USB type-A port.
It causes USB type-A port to be blocked, so we need this internal pull-up.

BUG=b:111578984
BRANCH=poppy
TEST=Verified over-current not triggered abnormally on basic sku board

Change-Id: I159f686cef9c8d254f390d7f1dff8011f43fc066
Signed-off-by: Seunghwan Kim <sh_.kim at samsung.com>
---
M src/mainboard/google/poppy/variants/nautilus/gpio.c
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/27542/1

diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c
index b496651..8b129d1 100644
--- a/src/mainboard/google/poppy/variants/nautilus/gpio.c
+++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c
@@ -224,8 +224,6 @@
 	PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1),
 	/* E10 : USB2_OC1# ==> USB3_C0_OC0_L */
 	PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1),
-	/* E11 : USB2_OC2# ==> USB2_P2_FAULT# */
-	PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1),
 	/* E12 : USB2_OC3# ==> NC */
 	PAD_CFG_NC(GPP_E12),
 	/* E13 : DDPB_HPD0 ==> KBC3_USB_C0_DP_HPD */
@@ -385,6 +383,8 @@
 	PAD_CFG_NC(GPP_D16),
 	/* D21 : SPI1_IO2 ==> NC */
 	PAD_CFG_NC(GPP_D21),
+	/* E11 : USB2_OC2# ==> USB2_P2_FAULT# */
+	PAD_CFG_NF(GPP_E11, 5K_PU, DEEP, NF1),
 };
 
 static const struct pad_config lte_sku_gpio_table[] = {
@@ -396,6 +396,8 @@
 	PAD_CFG_GPO(GPP_D16, 1, DEEP),
 	/* D21 : SPI1_IO2 ==> LTE3_BODY_SAR */
 	PAD_CFG_GPO(GPP_D21, 0, DEEP),
+	/* E11 : USB2_OC2# ==> USB2_P2_FAULT# */
+	PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1),
 };
 
 const struct pad_config *variant_sku_gpio_table(size_t *num)

-- 
To view, visit https://review.coreboot.org/27542
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I159f686cef9c8d254f390d7f1dff8011f43fc066
Gerrit-Change-Number: 27542
Gerrit-PatchSet: 1
Gerrit-Owner: Seunghwan Kim <sh_.kim at samsung.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180719/8db43af9/attachment.html>