[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: Add internal pull-up for USB2_OC2#

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27542 )

Change subject: mb/google/poppy/variants/nautilus: Add internal pull-up for USB2_OC2#
......................................................................


Patch Set 1:

(1 comment)

Can you please upload this change to poppy branch as well?

https://review.coreboot.org/#/c/27542/1/src/mainboard/google/poppy/variants/nautilus/gpio.c
File src/mainboard/google/poppy/variants/nautilus/gpio.c:

https://review.coreboot.org/#/c/27542/1/src/mainboard/google/poppy/variants/nautilus/gpio.c@a223
PS1, Line 223: 
OC0 and OC1 also don't have external pulls. Don't you need internal pulls on those lines?



-- 
To view, visit https://review.coreboot.org/27542
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I159f686cef9c8d254f390d7f1dff8011f43fc066
Gerrit-Change-Number: 27542
Gerrit-PatchSet: 1
Gerrit-Owner: Seunghwan Kim <sh_.kim at samsung.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 19 Jul 2018 06:13:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180719/15c35702/attachment.html>