<p>Seunghwan Kim has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27542">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nautilus: Add internal pull-up for USB2_OC2#<br><br>Nautilus-WiFi board doesn't have external pull-up on USB2_OC2# route, then<br>abnormal over-current is asserted on USB type-A port.<br>It causes USB type-A port to be blocked, so we need this internal pull-up.<br><br>BUG=b:111578984<br>BRANCH=poppy<br>TEST=Verified over-current not triggered abnormally on basic sku board<br><br>Change-Id: I159f686cef9c8d254f390d7f1dff8011f43fc066<br>Signed-off-by: Seunghwan Kim <sh_.kim@samsung.com><br>---<br>M src/mainboard/google/poppy/variants/nautilus/gpio.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/27542/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c</span><br><span>index b496651..8b129d1 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nautilus/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c</span><br><span>@@ -224,8 +224,6 @@</span><br><span>      PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1),</span><br><span>         /* E10 : USB2_OC1# ==> USB3_C0_OC0_L */</span><br><span>   PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">-   /* E11 : USB2_OC2# ==> USB2_P2_FAULT# */</span><br><span style="color: hsl(0, 100%, 40%);">-     PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1),</span><br><span>        /* E12 : USB2_OC3# ==> NC */</span><br><span>      PAD_CFG_NC(GPP_E12),</span><br><span>         /* E13 : DDPB_HPD0 ==> KBC3_USB_C0_DP_HPD */</span><br><span>@@ -385,6 +383,8 @@</span><br><span>        PAD_CFG_NC(GPP_D16),</span><br><span>         /* D21 : SPI1_IO2 ==> NC */</span><br><span>       PAD_CFG_NC(GPP_D21),</span><br><span style="color: hsl(120, 100%, 40%);">+  /* E11 : USB2_OC2# ==> USB2_P2_FAULT# */</span><br><span style="color: hsl(120, 100%, 40%);">+   PAD_CFG_NF(GPP_E11, 5K_PU, DEEP, NF1),</span><br><span> };</span><br><span> </span><br><span> static const struct pad_config lte_sku_gpio_table[] = {</span><br><span>@@ -396,6 +396,8 @@</span><br><span>    PAD_CFG_GPO(GPP_D16, 1, DEEP),</span><br><span>       /* D21 : SPI1_IO2 ==> LTE3_BODY_SAR */</span><br><span>    PAD_CFG_GPO(GPP_D21, 0, DEEP),</span><br><span style="color: hsl(120, 100%, 40%);">+        /* E11 : USB2_OC2# ==> USB2_P2_FAULT# */</span><br><span style="color: hsl(120, 100%, 40%);">+   PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1),</span><br><span> };</span><br><span> </span><br><span> const struct pad_config *variant_sku_gpio_table(size_t *num)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27542">change 27542</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27542"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I159f686cef9c8d254f390d7f1dff8011f43fc066 </div>
<div style="display:none"> Gerrit-Change-Number: 27542 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Seunghwan Kim <sh_.kim@samsung.com> </div>