[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Enable TBMC device only for phaser
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Wed Jul 11 03:35:10 CEST 2018
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27429
Change subject: mb/google/octopus: Enable TBMC device only for phaser
......................................................................
mb/google/octopus: Enable TBMC device only for phaser
Enabling of TBMC device on AP side requires corresponding support on the
EC side as well. Since not all octopus variants have tablet mode support
enabled, this change enables TBMC device only for phaser.
BUG=b:111264961
Change-Id: I1ce181baa8ebaff0a9d767e97ddc256eef9789e8
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h
M src/mainboard/google/octopus/variants/phaser/include/variant/ec.h
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/27429/1
diff --git a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h
index 3398875..471495a 100644
--- a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h
@@ -67,9 +67,6 @@
#define EC_ENABLE_LID_SWITCH
#define EC_ENABLE_WAKE_PIN GPE_EC_WAKE
-/* Enable Tablet switch */
-#define EC_ENABLE_TBMC_DEVICE
-
/* Enable EC backed PD MCU device in ACPI */
#define EC_ENABLE_PD_MCU_DEVICE
diff --git a/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h b/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h
index 16f931b..48cb584 100644
--- a/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h
+++ b/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h
@@ -18,4 +18,7 @@
#include <baseboard/ec.h>
+/* Enable Tablet switch */
+#define EC_ENABLE_TBMC_DEVICE
+
#endif
--
To view, visit https://review.coreboot.org/27429
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ce181baa8ebaff0a9d767e97ddc256eef9789e8
Gerrit-Change-Number: 27429
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180711/438eeaf7/attachment.html>
More information about the coreboot-gerrit
mailing list