<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27429">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus: Enable TBMC device only for phaser<br><br>Enabling of TBMC device on AP side requires corresponding support on the<br>EC side as well. Since not all octopus variants have tablet mode support<br>enabled, this change enables TBMC device only for phaser.<br><br>BUG=b:111264961<br><br>Change-Id: I1ce181baa8ebaff0a9d767e97ddc256eef9789e8<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h<br>M src/mainboard/google/octopus/variants/phaser/include/variant/ec.h<br>2 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/27429/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h</span><br><span>index 3398875..471495a 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h</span><br><span>+++ b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h</span><br><span>@@ -67,9 +67,6 @@</span><br><span> #define EC_ENABLE_LID_SWITCH</span><br><span> #define EC_ENABLE_WAKE_PIN      GPE_EC_WAKE</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Enable Tablet switch */</span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_ENABLE_TBMC_DEVICE</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Enable EC backed PD MCU device in ACPI */</span><br><span> #define EC_ENABLE_PD_MCU_DEVICE</span><br><span> </span><br><span>diff --git a/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h b/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h</span><br><span>index 16f931b..48cb584 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h</span><br><span>+++ b/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h</span><br><span>@@ -18,4 +18,7 @@</span><br><span> </span><br><span> #include <baseboard/ec.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Enable Tablet switch */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_ENABLE_TBMC_DEVICE</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #endif</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27429">change 27429</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27429"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1ce181baa8ebaff0a9d767e97ddc256eef9789e8 </div>
<div style="display:none"> Gerrit-Change-Number: 27429 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>