[coreboot-gerrit] Change in coreboot[master]: buildgcc: Actually verify checksums
Martin Roth (Code Review)
gerrit at coreboot.org
Wed Jul 11 00:31:20 CEST 2018
Martin Roth has posted comments on this change. ( https://review.coreboot.org/27426 )
Change subject: buildgcc: Actually verify checksums
......................................................................
Patch Set 1:
(2 comments)
Welcome, and thanks for the patch.
> Build Unstable
> https://qa.coreboot.org/job/coreboot-toolchain/444/ : UNSTABLE
This is obviously not the fault of this patch. I need to get the builders updated to the new toolchain.
https://review.coreboot.org/#/c/27426/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/27426/1//COMMIT_MSG@2
PS1, Line 2: olidHal <SolidHal at users.noreply.github.com>
Could we get a real name and contact information?
https://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
https://review.coreboot.org/#/c/27426/1/util/crossgcc/buildgcc
File util/crossgcc/buildgcc:
https://review.coreboot.org/#/c/27426/1/util/crossgcc/buildgcc@323
PS1, Line 323:
Tabs, here and below.
--
To view, visit https://review.coreboot.org/27426
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I132f5f86cd31a001372b19e0f81ad933916d2a83
Gerrit-Change-Number: 27426
Gerrit-PatchSet: 1
Gerrit-Owner: SolidHal (1002051)
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Tue, 10 Jul 2018 22:31:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180710/caaa1cc5/attachment.html>
More information about the coreboot-gerrit
mailing list