[coreboot-gerrit] Change in coreboot[master]: buildgcc: Actually verify checksums
SolidHal (Code Review)
gerrit at coreboot.org
Tue Jul 10 21:58:32 CEST 2018
SolidHal has uploaded this change for review. ( https://review.coreboot.org/27426
Change subject: buildgcc: Actually verify checksums
......................................................................
buildgcc: Actually verify checksums
buildgcc doesn't verify the checksum of gcc downloaded using download(). This can be verified by modifying
the gcc checksum in coreboot/util/crossgcc/sum, which won't cause a failure without this patch
Change-Id: I132f5f86cd31a001372b19e0f81ad933916d2a83
Signed-off-by: SolidHal <SolidHal at users.noreply.github.com>
---
M util/crossgcc/buildgcc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/27426/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index a9d9057..5083773 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -320,6 +320,10 @@
cd tarballs
download_showing_percentage $archive
cd ..
+ if ! check_sum $FILE; then
+ printf "\n${RED}$FILE Failed Checksum Verification${NC}\n"
+ exit 1
+ fi
fi
if [ ! -f tarballs/$FILE ]; then
--
To view, visit https://review.coreboot.org/27426
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I132f5f86cd31a001372b19e0f81ad933916d2a83
Gerrit-Change-Number: 27426
Gerrit-PatchSet: 1
Gerrit-Owner: SolidHal (1002051)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180710/b0211345/attachment.html>
More information about the coreboot-gerrit
mailing list