[coreboot-gerrit] Change in coreboot[master]: buildgcc: Actually verify checksums

SolidHal (Code Review) gerrit at coreboot.org
Wed Jul 11 18:30:35 CEST 2018


SolidHal has uploaded this change for review. ( https://review.coreboot.org/27436


Change subject: buildgcc: Actually verify checksums
......................................................................

buildgcc: Actually verify checksums

buildgcc doesn't verify the checksum of gcc downloaded using download().
This can be verified by modifying the gcc checksum in coreboot/util/crossgcc/sum,
which won't cause a failure without this patch

Change-Id: Idcd583f853d0a3db5e6ccd25c27bc486c2c49691
Signed-off-by: Hal Emmerich <Hal at halemmerich.com>
---
M util/crossgcc/buildgcc
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/27436/1

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 5083773..788bb65 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -320,10 +320,10 @@
 		cd tarballs
 		download_showing_percentage $archive
 		cd ..
-    if ! check_sum $FILE; then
-			  printf "\n${RED}$FILE Failed Checksum Verification${NC}\n"
-        exit 1
-    fi
+		if ! check_sum $FILE; then
+				printf "\n${RED}$FILE Failed Checksum Verification${NC}\n"
+				exit 1
+		fi
 	fi
 
 	if [ ! -f tarballs/$FILE ]; then

-- 
To view, visit https://review.coreboot.org/27436
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcd583f853d0a3db5e6ccd25c27bc486c2c49691
Gerrit-Change-Number: 27436
Gerrit-PatchSet: 1
Gerrit-Owner: SolidHal (1002051)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180711/ef38d705/attachment.html>


More information about the coreboot-gerrit mailing list