[coreboot-gerrit] Change in coreboot[master]: nocturne: Do not set 4 LSB of SX9310 CRTL0

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27265 )

Change subject: nocturne: Do not set 4 LSB of SX9310 CRTL0
......................................................................

nocturne: Do not set 4 LSB of SX9310 CRTL0

These bits start the acquisition process. They should only be set by the
driver.

BUG=b:74363445
TEST=compile

Change-Id: I9e10f5570ac82124f7f4b5cc7aaad27da0c578be
Signed-off-by: Gwendal Grignou <gwendal at chromium.org>
Reviewed-on: https://review.coreboot.org/27265
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved



diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index 09b7ef9..17bd3c0 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -305,7 +305,7 @@
 				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D9_IRQ)"
 				register "speed" = "I2C_SPEED_FAST_PLUS"
 				register "uid" = "0"
-				register "reg_prox_ctrl0" = "0x1a"
+				register "reg_prox_ctrl0" = "0x10"
 				register "reg_prox_ctrl1" = "0x00"
 				register "reg_prox_ctrl2" = "0x84"
 				register "reg_prox_ctrl3" = "0x0e"
@@ -346,7 +346,7 @@
 				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D10_IRQ)"
 				register "speed" = "I2C_SPEED_FAST_PLUS"
 				register "uid" = "1"
-				register "reg_prox_ctrl0" = "0x1a"
+				register "reg_prox_ctrl0" = "0x10"
 				register "reg_prox_ctrl1" = "0x00"
 				register "reg_prox_ctrl2" = "0x84"
 				register "reg_prox_ctrl3" = "0x0e"

-- 
To view, visit https://review.coreboot.org/27265
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e10f5570ac82124f7f4b5cc7aaad27da0c578be
Gerrit-Change-Number: 27265
Gerrit-PatchSet: 4
Gerrit-Owner: Gwendal Grignou <gwendal at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Gwendal Grignou <gwendal at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180702/c7453afa/attachment.html>