[coreboot-gerrit] Change in coreboot[master]: nocturne: Fix casing for register definition

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Jul 2 09:25:10 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27264 )

Change subject: nocturne: Fix casing for register definition
......................................................................

nocturne: Fix casing for register definition

Use lower case for hex values.

BUG=b:74363445
TEST=compile

Change-Id: I24afea58b1a791fac3c87ad397a696f7f6e0d127
Signed-off-by: Gwendal Grignou <gwendal at chromium.org>
Reviewed-on: https://review.coreboot.org/27264
Reviewed-by: Furquan Shaikh <furquan at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
1 file changed, 14 insertions(+), 14 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved



diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index 91c0b44..09b7ef9 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -305,15 +305,15 @@
 				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D9_IRQ)"
 				register "speed" = "I2C_SPEED_FAST_PLUS"
 				register "uid" = "0"
-				register "reg_prox_ctrl0" = "0x1A"
+				register "reg_prox_ctrl0" = "0x1a"
 				register "reg_prox_ctrl1" = "0x00"
 				register "reg_prox_ctrl2" = "0x84"
-				register "reg_prox_ctrl3" = "0x0E"
+				register "reg_prox_ctrl3" = "0x0e"
 				register "reg_prox_ctrl4" = "0x07"
-				register "reg_prox_ctrl5" = "0xC6"
+				register "reg_prox_ctrl5" = "0xc6"
 				register "reg_prox_ctrl6" = "0x20"
-				register "reg_prox_ctrl7" = "0x0D"
-				register "reg_prox_ctrl8" = "0x8D"
+				register "reg_prox_ctrl7" = "0x0d"
+				register "reg_prox_ctrl8" = "0x8d"
 				register "reg_prox_ctrl9" = "0x43"
 				register "reg_prox_ctrl10" = "0x11"
 				register "reg_prox_ctrl11" = "0x00"
@@ -326,8 +326,8 @@
 				register "reg_prox_ctrl18" = "0x00"
 				register "reg_prox_ctrl19" = "0x00"
 				register "reg_sar_ctrl0" = "0x50"
-				register "reg_sar_ctrl1" = "0x8A"
-				register "reg_sar_ctrl2" = "0x3C"
+				register "reg_sar_ctrl1" = "0x8a"
+				register "reg_sar_ctrl2" = "0x3c"
 				device i2c 28 on end
 			end
 		end # I2C #1
@@ -346,15 +346,15 @@
 				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D10_IRQ)"
 				register "speed" = "I2C_SPEED_FAST_PLUS"
 				register "uid" = "1"
-				register "reg_prox_ctrl0" = "0x1A"
+				register "reg_prox_ctrl0" = "0x1a"
 				register "reg_prox_ctrl1" = "0x00"
 				register "reg_prox_ctrl2" = "0x84"
-				register "reg_prox_ctrl3" = "0x0E"
+				register "reg_prox_ctrl3" = "0x0e"
 				register "reg_prox_ctrl4" = "0x07"
-				register "reg_prox_ctrl5" = "0xC6"
+				register "reg_prox_ctrl5" = "0xc6"
 				register "reg_prox_ctrl6" = "0x20"
-				register "reg_prox_ctrl7" = "0x0D"
-				register "reg_prox_ctrl8" = "0x8D"
+				register "reg_prox_ctrl7" = "0x0d"
+				register "reg_prox_ctrl8" = "0x8d"
 				register "reg_prox_ctrl9" = "0x43"
 				register "reg_prox_ctrl10" = "0x11"
 				register "reg_prox_ctrl11" = "0x00"
@@ -367,8 +367,8 @@
 				register "reg_prox_ctrl18" = "0x00"
 				register "reg_prox_ctrl19" = "0x00"
 				register "reg_sar_ctrl0" = "0x50"
-				register "reg_sar_ctrl1" = "0x8A"
-				register "reg_sar_ctrl2" = "0x3C"
+				register "reg_sar_ctrl1" = "0x8a"
+				register "reg_sar_ctrl2" = "0x3c"
 				device i2c 28 on end
 			end
 		end # I2C #5

-- 
To view, visit https://review.coreboot.org/27264
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I24afea58b1a791fac3c87ad397a696f7f6e0d127
Gerrit-Change-Number: 27264
Gerrit-PatchSet: 2
Gerrit-Owner: Gwendal Grignou <gwendal at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180702/b329fc6c/attachment.html>


More information about the coreboot-gerrit mailing list