<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/27265">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Furquan Shaikh: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nocturne: Do not set 4 LSB of SX9310 CRTL0<br><br>These bits start the acquisition process. They should only be set by the<br>driver.<br><br>BUG=b:74363445<br>TEST=compile<br><br>Change-Id: I9e10f5570ac82124f7f4b5cc7aaad27da0c578be<br>Signed-off-by: Gwendal Grignou <gwendal@chromium.org><br>Reviewed-on: https://review.coreboot.org/27265<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/devicetree.cb<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>index 09b7ef9..17bd3c0 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>@@ -305,7 +305,7 @@</span><br><span> register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D9_IRQ)"</span><br><span> register "speed" = "I2C_SPEED_FAST_PLUS"</span><br><span> register "uid" = "0"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl0" = "0x1a"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl0" = "0x10"</span><br><span> register "reg_prox_ctrl1" = "0x00"</span><br><span> register "reg_prox_ctrl2" = "0x84"</span><br><span> register "reg_prox_ctrl3" = "0x0e"</span><br><span>@@ -346,7 +346,7 @@</span><br><span> register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D10_IRQ)"</span><br><span> register "speed" = "I2C_SPEED_FAST_PLUS"</span><br><span> register "uid" = "1"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl0" = "0x1a"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl0" = "0x10"</span><br><span> register "reg_prox_ctrl1" = "0x00"</span><br><span> register "reg_prox_ctrl2" = "0x84"</span><br><span> register "reg_prox_ctrl3" = "0x0e"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27265">change 27265</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27265"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9e10f5570ac82124f7f4b5cc7aaad27da0c578be </div>
<div style="display:none"> Gerrit-Change-Number: 27265 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Gwendal Grignou <gwendal@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Gwendal Grignou <gwendal@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>