[coreboot-gerrit] Change in coreboot[master]: google/lars: Turn on keyboard backlight in romstage

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/23572


Change subject: google/lars: Turn on keyboard backlight in romstage
......................................................................

google/lars: Turn on keyboard backlight in romstage

Cherry-pick from Chromium:
a60ac10 [Lars: Turn on keyboard backlight in romstage]

Use the keyboard backlight to provide indication that the system is
booting.  This is useful for determining that a system is in S0 and
is running BIOS code.

TEST=boot on Lars and see keyboard backlight come on early

Original-Change-Id: I4fede6cff85f4487cedfbccf6cc24c6380d905e0
Original-Signed-off-by: Jenny TC <jenny.tc at intel.com>
Original-Tested-by: Divagar Mohandass <divagar.mohandass at intel.com>
Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>

Change-Id: I4b1fed10d9bd1ae1b265e848417836f816f252f3
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/lars/romstage.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/23572/1

diff --git a/src/mainboard/google/lars/romstage.c b/src/mainboard/google/lars/romstage.c
index 926be87..b3ef0d8 100644
--- a/src/mainboard/google/lars/romstage.c
+++ b/src/mainboard/google/lars/romstage.c
@@ -17,6 +17,7 @@
 
 #include <string.h>
 #include <gpio.h>
+#include <ec/google/chromeec/ec.h>
 #include <soc/pei_data.h>
 #include <soc/pei_wrapper.h>
 #include <soc/romstage.h>
@@ -33,6 +34,10 @@
 		GPIO_MEM_CONFIG_3,
 	};
 
+	/* Turn on keyboard backlight to indicate we are booting */
+	if (params->power_state->prev_sleep_state != ACPI_S3)
+		google_chromeec_kbbacklight(25);
+
 	params->pei_data->mem_cfg_id = gpio_base2_value(spd_gpios,
 							ARRAY_SIZE(spd_gpios));
 	/* Fill out PEI DATA */

-- 
To view, visit https://review.coreboot.org/23572
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b1fed10d9bd1ae1b265e848417836f816f252f3
Gerrit-Change-Number: 23572
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Jenny Tc <jenny.tc at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180202/8b9c5635/attachment.html>