[coreboot-gerrit] Change in coreboot[master]: google/lars: Turn on keyboard backlight in romstage

Matt DeVillier (Code Review) gerrit at coreboot.org
Fri Feb 2 20:10:45 CET 2018


Hello Jenny Tc, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/23572

to look at the new patch set (#2).

Change subject: google/lars: Turn on keyboard backlight in romstage
......................................................................

google/lars: Turn on keyboard backlight in romstage

Cherry-pick from Chromium:
a60ac10 [Lars: Turn on keyboard backlight in romstage]

Use the keyboard backlight to provide indication that the system is
booting.  This is useful for determining that a system is in S0 and
is running BIOS code.

TEST=boot on Lars and see keyboard backlight come on early

Original-Change-Id: I4fede6cff85f4487cedfbccf6cc24c6380d905e0
Original-Signed-off-by: Jenny TC <jenny.tc at intel.com>
Original-Tested-by: Divagar Mohandass <divagar.mohandass at intel.com>
Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>

Change-Id: I4b1fed10d9bd1ae1b265e848417836f816f252f3
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/lars/romstage.c
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/23572/2
-- 
To view, visit https://review.coreboot.org/23572
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b1fed10d9bd1ae1b265e848417836f816f252f3
Gerrit-Change-Number: 23572
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Jenny Tc <jenny.tc at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180202/40648411/attachment.html>


More information about the coreboot-gerrit mailing list