<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23572">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/lars: Turn on keyboard backlight in romstage<br><br>Cherry-pick from Chromium:<br>a60ac10 [Lars: Turn on keyboard backlight in romstage]<br><br>Use the keyboard backlight to provide indication that the system is<br>booting.  This is useful for determining that a system is in S0 and<br>is running BIOS code.<br><br>TEST=boot on Lars and see keyboard backlight come on early<br><br>Original-Change-Id: I4fede6cff85f4487cedfbccf6cc24c6380d905e0<br>Original-Signed-off-by: Jenny TC <jenny.tc@intel.com><br>Original-Tested-by: Divagar Mohandass <divagar.mohandass@intel.com><br>Original-Reviewed-by: Duncan Laurie <dlaurie@chromium.org><br><br>Change-Id: I4b1fed10d9bd1ae1b265e848417836f816f252f3<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/lars/romstage.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/23572/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/lars/romstage.c b/src/mainboard/google/lars/romstage.c</span><br><span>index 926be87..b3ef0d8 100644</span><br><span>--- a/src/mainboard/google/lars/romstage.c</span><br><span>+++ b/src/mainboard/google/lars/romstage.c</span><br><span>@@ -17,6 +17,7 @@</span><br><span> </span><br><span> #include <string.h></span><br><span> #include <gpio.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <ec/google/chromeec/ec.h></span><br><span> #include <soc/pei_data.h></span><br><span> #include <soc/pei_wrapper.h></span><br><span> #include <soc/romstage.h></span><br><span>@@ -33,6 +34,10 @@</span><br><span>           GPIO_MEM_CONFIG_3,</span><br><span>   };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        /* Turn on keyboard backlight to indicate we are booting */</span><br><span style="color: hsl(120, 100%, 40%);">+   if (params->power_state->prev_sleep_state != ACPI_S3)</span><br><span style="color: hsl(120, 100%, 40%);">+           google_chromeec_kbbacklight(25);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   params->pei_data->mem_cfg_id = gpio_base2_value(spd_gpios,</span><br><span>                                                     ARRAY_SIZE(spd_gpios));</span><br><span>      /* Fill out PEI DATA */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23572">change 23572</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23572"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4b1fed10d9bd1ae1b265e848417836f816f252f3 </div>
<div style="display:none"> Gerrit-Change-Number: 23572 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenny Tc <jenny.tc@intel.com> </div>