[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add memory init setup for hatch

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30248 )

Change subject: mb/google/hatch: Add memory init setup for hatch
......................................................................


Patch Set 11:

(4 comments)

https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/spd/hynix_dimm_H5AN8G6NCJR-VKC-8GB.spd.hex 
File src/mainboard/google/hatch/spd/hynix_dimm_H5AN8G6NCJR-VKC-8GB.spd.hex:

PS11: 
Shelley is working on adding the SPD files differently. Do you want to add this later on?


https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/spd/samsung_dimm_K4A4G165WE-BCRC-4GB.spd.hex 
File src/mainboard/google/hatch/spd/samsung_dimm_K4A4G165WE-BCRC-4GB.spd.hex:

PS11: 
same here.


https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/variants/baseboard/Makefile.inc 
File src/mainboard/google/hatch/variants/baseboard/Makefile.inc:

https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/variants/baseboard/Makefile.inc@15 
PS11, Line 15: SPD_SOURCES = samsung_dimm_K4A4G165WE-BCRC-4GB	# 0b000
             : SPD_SOURCES += empty_ddr4	# 0b001
             : SPD_SOURCES += empty_ddr4	# 0b010
             : SPD_SOURCES += empty_ddr4	# 0b011
             : SPD_SOURCES += empty_ddr4	# 0b100
             : SPD_SOURCES += hynix_dimm_H5AN8G6NCJR-VKC-8GB	# 0b101
Shelley is working on doing this differently.


https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h 
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h:

https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h@22 
PS11, Line 22: define GPIO_MEM_CONFIG_0	GPP_F20
             : #define GPIO_MEM_CONFIG_1	GPP_F21
             : #define GPIO_MEM_CONFIG_2	GPP_F11
             : #define GPIO_MEM_CONFIG_3	GPP_F22
These gpios should be configured in gpio.c as well.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30248
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bda08bd0b9f91ebb96b39291e15473492a6bf19
Gerrit-Change-Number: 30248
Gerrit-PatchSet: 11
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 14:18:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/998c2f5e/attachment.html>