<p><a href="https://review.coreboot.org/c/coreboot/+/30248">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/spd/hynix_dimm_H5AN8G6NCJR-VKC-8GB.spd.hex">File src/mainboard/google/hatch/spd/hynix_dimm_H5AN8G6NCJR-VKC-8GB.spd.hex:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/spd/hynix_dimm_H5AN8G6NCJR-VKC-8GB.spd.hex">Patch Set #11:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Shelley is working on adding the SPD files differently. Do you want to add this later on?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/spd/samsung_dimm_K4A4G165WE-BCRC-4GB.spd.hex">File src/mainboard/google/hatch/spd/samsung_dimm_K4A4G165WE-BCRC-4GB.spd.hex:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/spd/samsung_dimm_K4A4G165WE-BCRC-4GB.spd.hex">Patch Set #11:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">same here.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/variants/baseboard/Makefile.inc">File src/mainboard/google/hatch/variants/baseboard/Makefile.inc:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/variants/baseboard/Makefile.inc@15">Patch Set #11, Line 15:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">SPD_SOURCES = samsung_dimm_K4A4G165WE-BCRC-4GB     # 0b000<br>SPD_SOURCES += empty_ddr4      # 0b001<br>SPD_SOURCES += empty_ddr4      # 0b010<br>SPD_SOURCES += empty_ddr4      # 0b011<br>SPD_SOURCES += empty_ddr4      # 0b100<br>SPD_SOURCES += hynix_dimm_H5AN8G6NCJR-VKC-8GB  # 0b101<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Shelley is working on doing this differently.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h">File src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30248/11/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h@22">Patch Set #11, Line 22:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">define GPIO_MEM_CONFIG_0        GPP_F20<br>#define GPIO_MEM_CONFIG_1      GPP_F21<br>#define GPIO_MEM_CONFIG_2      GPP_F11<br>#define GPIO_MEM_CONFIG_3      GPP_F22<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">These gpios should be configured in gpio.c as well.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30248">change 30248</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30248"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9bda08bd0b9f91ebb96b39291e15473492a6bf19 </div>
<div style="display:none"> Gerrit-Change-Number: 30248 </div>
<div style="display:none"> Gerrit-PatchSet: 11 </div>
<div style="display:none"> Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Shelley Chen <shchen@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 20 Dec 2018 14:18:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>