[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add memory init setup for hatch

Aamir Bohra (Code Review) gerrit at coreboot.org
Thu Dec 20 11:01:45 CET 2018


Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30248 )

Change subject: mb/google/hatch: Add memory init setup for hatch
......................................................................


Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/30248/9/src/mainboard/google/hatch/spd/empty_ddr4.spd.hex 
File src/mainboard/google/hatch/spd/empty_ddr4.spd.hex:

https://review.coreboot.org/#/c/30248/9/src/mainboard/google/hatch/spd/empty_ddr4.spd.hex@1 
PS9, Line 1: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> delete this ?
needed to empty spd index padding.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30248
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bda08bd0b9f91ebb96b39291e15473492a6bf19
Gerrit-Change-Number: 30248
Gerrit-PatchSet: 11
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 10:01:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik at intel.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/b6e615a8/attachment.html>


More information about the coreboot-gerrit mailing list