[coreboot-gerrit] Change in ...coreboot[master]: mb/foxconn/g41s-k: Don't reprogram inherited subsystemid
Patrick Georgi (Code Review)
gerrit at coreboot.org
Wed Dec 19 06:37:29 CET 2018
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30241 )
Change subject: mb/foxconn/g41s-k: Don't reprogram inherited subsystemid
......................................................................
mb/foxconn/g41s-k: Don't reprogram inherited subsystemid
Change-Id: I85b5aef758a1ed30c46ed0adabec3293edb0f3fd
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/30241
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Tristan Corrick <tristan at corrick.kiwi>
---
M src/mainboard/foxconn/g41s-k/devicetree.cb
1 file changed, 11 insertions(+), 34 deletions(-)
Approvals:
build bot (Jenkins): Verified
Tristan Corrick: Looks good to me, approved
diff --git a/src/mainboard/foxconn/g41s-k/devicetree.cb b/src/mainboard/foxconn/g41s-k/devicetree.cb
index a638457..84cf353 100644
--- a/src/mainboard/foxconn/g41s-k/devicetree.cb
+++ b/src/mainboard/foxconn/g41s-k/devicetree.cb
@@ -27,13 +27,9 @@
end
device domain 0 on # PCI domain
subsystemid 0x105b 0x0dda inherit
- device pci 0.0 on # Host Bridge
- subsystemid 0x105b 0x0dda
- end
+ device pci 0.0 on end # Host Bridge
device pci 1.0 on end # PEG
- device pci 2.0 on # Integrated graphics controller
- subsystemid 0x105b 0x0dda
- end
+ device pci 2.0 on end # Integrated graphics controller
device pci 2.1 off end # Integrated graphics controller 2
device pci 3.0 off end # ME
device pci 3.1 off end # ME
@@ -55,39 +51,24 @@
register "sata_ahci" = "0x0" # AHCI does not work
register "sata_ports_implemented" = "0x3"
- device pci 1b.0 on # Audio
- subsystemid 0x105b 0x0dda
- end
+ device pci 1b.0 on end # Audio
device pci 1c.0 on end # PCIe 1
device pci 1c.1 on # PCIe 2 (NIC)
- device pci 00.0 on # PCI 10ec:8168
- subsystemid 0x105b 0x0dda
- end
+ device pci 00.0 on end # PCI 10ec:8168
end
device pci 1c.2 off end # PCIe 3
device pci 1c.3 off end # PCIe 4
device pci 1c.4 off end # PCIe 5
device pci 1c.5 off end # PCIe 6
- device pci 1d.0 on # USB
- subsystemid 0x105b 0x0dda
- end
- device pci 1d.1 on # USB
- subsystemid 0x105b 0x0dda
- end
- device pci 1d.2 on # USB
- subsystemid 0x105b 0x0dda
- end
- device pci 1d.3 on # USB
- subsystemid 0x105b 0x0dda
- end
- device pci 1d.7 on # USB
- subsystemid 0x105b 0x0dda
- end
+ device pci 1d.0 on end # USB
+ device pci 1d.1 on end # USB
+ device pci 1d.2 on end # USB
+ device pci 1d.3 on end # USB
+ device pci 1d.7 on end # USB
device pci 1e.0 on end # PCI bridge
device pci 1e.2 off end # AC'97 Audio
device pci 1e.3 off end # AC'97 Modem
device pci 1f.0 on # ISA bridge
- subsystemid 0x105b 0x0dda
chip superio/ite/it8720f # Super I/O
register "TMPIN1.mode" = "THERMAL_DIODE"
register "TMPIN1.offset" = "0"
@@ -179,12 +160,8 @@
end
end
device pci 1f.1 off end # PATA/IDE
- device pci 1f.2 on # SATA
- subsystemid 0x105b 0x0dda
- end
- device pci 1f.3 on # SMbus
- subsystemid 0x105b 0x0dda
- end
+ device pci 1f.2 on end # SATA
+ device pci 1f.3 on end # SMbus
end
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/30241
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85b5aef758a1ed30c46ed0adabec3293edb0f3fd
Gerrit-Change-Number: 30241
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/94ed3485/attachment.html>
More information about the coreboot-gerrit
mailing list