[coreboot-gerrit] Change in ...coreboot[master]: mb/asus/kgpe-d16: Set ASpeed GPIO SPD mux lines during boot

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/19820 )

Change subject: mb/asus/kgpe-d16: Set ASpeed GPIO SPD mux lines during boot
......................................................................


Patch Set 9:

(3 comments)

https://review.coreboot.org/#/c/19820/9/src/mainboard/asus/kgpe-d16/romstage.c 
File src/mainboard/asus/kgpe-d16/romstage.c:

https://review.coreboot.org/#/c/19820/9/src/mainboard/asus/kgpe-d16/romstage.c@131 
PS9, Line 131: 	/* Use the P2A bridge to set ASpeed SPD mux GPIOs to the same values as the SP5100 */
line over 80 characters


https://review.coreboot.org/#/c/19820/9/src/mainboard/asus/kgpe-d16/romstage.c@132 
PS9, Line 132: 	void* ast_bar1 = (void*)memory_base;
"(foo*)" should be "(foo *)"


https://review.coreboot.org/#/c/19820/9/src/mainboard/asus/kgpe-d16/romstage.c@132 
PS9, Line 132: 	void* ast_bar1 = (void*)memory_base;
"foo* bar" should be "foo *bar"



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/19820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia251334ae44668c2260d8d2e816f85f1f62faac5
Gerrit-Change-Number: 19820
Gerrit-PatchSet: 9
Gerrit-Owner: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: James Hebden <james at hebden.net.au>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Comment-Date: Mon, 17 Dec 2018 13:14:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181217/756b5949/attachment.html>