<p><a href="https://review.coreboot.org/c/coreboot/+/19820">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/19820/9/src/mainboard/asus/kgpe-d16/romstage.c">File src/mainboard/asus/kgpe-d16/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/19820/9/src/mainboard/asus/kgpe-d16/romstage.c@131">Patch Set #9, Line 131:</a> <code style="font-family:monospace,monospace">        /* Use the P2A bridge to set ASpeed SPD mux GPIOs to the same values as the SP5100 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/19820/9/src/mainboard/asus/kgpe-d16/romstage.c@132">Patch Set #9, Line 132:</a> <code style="font-family:monospace,monospace">       void* ast_bar1 = (void*)memory_base;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"(foo*)" should be "(foo *)"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/19820/9/src/mainboard/asus/kgpe-d16/romstage.c@132">Patch Set #9, Line 132:</a> <code style="font-family:monospace,monospace">       void* ast_bar1 = (void*)memory_base;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/19820">change 19820</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/19820"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia251334ae44668c2260d8d2e816f85f1f62faac5 </div>
<div style="display:none"> Gerrit-Change-Number: 19820 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: Timothy Pearson <tpearson@raptorengineering.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: James Hebden <james@hebden.net.au> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Timothy Pearson <tpearson@raptorengineering.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 17 Dec 2018 13:14:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>