[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/broadwell: implement RMRR ACPI table

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30234 )

Change subject: soc/intel/broadwell: implement RMRR ACPI table
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://review.coreboot.org/#/c/30234/1/src/soc/intel/broadwell/Kconfig 
File src/soc/intel/broadwell/Kconfig:

https://review.coreboot.org/#/c/30234/1/src/soc/intel/broadwell/Kconfig@40 
PS1, Line 40: 	select SOC_INTEL_COMMON_BLOCK_SA
This does not only enable the library code but also adds an (inactive because of mismatching PCI ids) pci device driver (see systemagent.c).

Maybe split that out: SOC_INTEL_COMMON_BLOCK_SA_LIB which only includes systemagent_early.c and is selected by SOC_INTEL_COMMON_BLOCK_SA. Then only select the former here.

We should still review *all* the newly enabled code if it's Broadwell compatible (not just the functions used here) otherwise somebody might assume that the existing functions are compatible while they aren't.


https://review.coreboot.org/#/c/30234/1/src/soc/intel/broadwell/include/soc/systemagent.h 
File src/soc/intel/broadwell/include/soc/systemagent.h:

https://review.coreboot.org/#/c/30234/1/src/soc/intel/broadwell/include/soc/systemagent.h@97 
PS1, Line 97: #ifndef MCHBAR32
This makes things even messier, IMHO. Can we find a way to clean it up beforehand? e.g. removing everything from this file that is defined in the common one would be a start (+ including intelblocks/systemagent.h where needed).



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30234
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a10a4f91b787b72f33150031b783d426148c25d
Gerrit-Change-Number: 30234
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 15 Dec 2018 12:57:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181215/d50f64ae/attachment.html>