[coreboot-gerrit] Change in ...coreboot[master]: google/rambi: disable TXE in devicetree for all variants
Matt DeVillier (Code Review)
gerrit at coreboot.org
Sat Dec 15 01:09:39 CET 2018
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30235
Change subject: google/rambi: disable TXE in devicetree for all variants
......................................................................
google/rambi: disable TXE in devicetree for all variants
The TXE PCI device serves no function under Linux, and doesn't
work properly under Windows, so disable/hide it from the OS.
Test: Boot Windows 10 on google/squawks, verify TXE not visible
under Device Manager.
Change-Id: Idaa152e15106b826fd5aa787090acd45719f4228
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/rambi/variants/banjo/devicetree.cb
M src/mainboard/google/rambi/variants/candy/devicetree.cb
M src/mainboard/google/rambi/variants/clapper/devicetree.cb
M src/mainboard/google/rambi/variants/enguarde/devicetree.cb
M src/mainboard/google/rambi/variants/glimmer/devicetree.cb
M src/mainboard/google/rambi/variants/gnawty/devicetree.cb
M src/mainboard/google/rambi/variants/heli/devicetree.cb
M src/mainboard/google/rambi/variants/kip/devicetree.cb
M src/mainboard/google/rambi/variants/ninja/devicetree.cb
M src/mainboard/google/rambi/variants/orco/devicetree.cb
M src/mainboard/google/rambi/variants/quawks/devicetree.cb
M src/mainboard/google/rambi/variants/rambi/devicetree.cb
M src/mainboard/google/rambi/variants/squawks/devicetree.cb
M src/mainboard/google/rambi/variants/sumo/devicetree.cb
M src/mainboard/google/rambi/variants/swanky/devicetree.cb
M src/mainboard/google/rambi/variants/winky/devicetree.cb
16 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/30235/1
diff --git a/src/mainboard/google/rambi/variants/banjo/devicetree.cb b/src/mainboard/google/rambi/variants/banjo/devicetree.cb
index acfb271..55d9873 100644
--- a/src/mainboard/google/rambi/variants/banjo/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/banjo/devicetree.cb
@@ -74,7 +74,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 off end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 off end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/candy/devicetree.cb b/src/mainboard/google/rambi/variants/candy/devicetree.cb
index e4a39e9..e048361 100644
--- a/src/mainboard/google/rambi/variants/candy/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/candy/devicetree.cb
@@ -75,7 +75,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 on end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 off end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/clapper/devicetree.cb b/src/mainboard/google/rambi/variants/clapper/devicetree.cb
index 497a0b1..1e50e53 100644
--- a/src/mainboard/google/rambi/variants/clapper/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/clapper/devicetree.cb
@@ -62,7 +62,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 on end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 off end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/enguarde/devicetree.cb b/src/mainboard/google/rambi/variants/enguarde/devicetree.cb
index 3b00bb7..0db28d5 100644
--- a/src/mainboard/google/rambi/variants/enguarde/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/enguarde/devicetree.cb
@@ -74,7 +74,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 off end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/glimmer/devicetree.cb b/src/mainboard/google/rambi/variants/glimmer/devicetree.cb
index db26366..5e7d646 100644
--- a/src/mainboard/google/rambi/variants/glimmer/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/glimmer/devicetree.cb
@@ -71,7 +71,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 on end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/gnawty/devicetree.cb b/src/mainboard/google/rambi/variants/gnawty/devicetree.cb
index 30320cc..3559d99 100644
--- a/src/mainboard/google/rambi/variants/gnawty/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/gnawty/devicetree.cb
@@ -74,7 +74,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 off end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/heli/devicetree.cb b/src/mainboard/google/rambi/variants/heli/devicetree.cb
index c3ec601..d6536c3 100644
--- a/src/mainboard/google/rambi/variants/heli/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/heli/devicetree.cb
@@ -75,7 +75,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 off end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/kip/devicetree.cb b/src/mainboard/google/rambi/variants/kip/devicetree.cb
index 5bb99f0..24facb3 100644
--- a/src/mainboard/google/rambi/variants/kip/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/kip/devicetree.cb
@@ -74,7 +74,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 off end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/ninja/devicetree.cb b/src/mainboard/google/rambi/variants/ninja/devicetree.cb
index c983681..b9e09e0 100644
--- a/src/mainboard/google/rambi/variants/ninja/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/ninja/devicetree.cb
@@ -75,7 +75,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 off end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 off end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/orco/devicetree.cb b/src/mainboard/google/rambi/variants/orco/devicetree.cb
index 63b6097..c612336 100644
--- a/src/mainboard/google/rambi/variants/orco/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/orco/devicetree.cb
@@ -74,7 +74,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 off end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/quawks/devicetree.cb b/src/mainboard/google/rambi/variants/quawks/devicetree.cb
index 0e1f789..ee0f38d 100644
--- a/src/mainboard/google/rambi/variants/quawks/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/quawks/devicetree.cb
@@ -71,7 +71,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 off end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/rambi/devicetree.cb b/src/mainboard/google/rambi/variants/rambi/devicetree.cb
index a24bd33..0fb7f14 100644
--- a/src/mainboard/google/rambi/variants/rambi/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/rambi/devicetree.cb
@@ -75,7 +75,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 on end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/squawks/devicetree.cb b/src/mainboard/google/rambi/variants/squawks/devicetree.cb
index ae4bfe5..4ed27be 100644
--- a/src/mainboard/google/rambi/variants/squawks/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/squawks/devicetree.cb
@@ -71,7 +71,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 off end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/sumo/devicetree.cb b/src/mainboard/google/rambi/variants/sumo/devicetree.cb
index f354815..8f093c6 100644
--- a/src/mainboard/google/rambi/variants/sumo/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/sumo/devicetree.cb
@@ -75,7 +75,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 on end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 off end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/swanky/devicetree.cb b/src/mainboard/google/rambi/variants/swanky/devicetree.cb
index d591e3f..57f8910 100644
--- a/src/mainboard/google/rambi/variants/swanky/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/swanky/devicetree.cb
@@ -74,7 +74,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 off end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
diff --git a/src/mainboard/google/rambi/variants/winky/devicetree.cb b/src/mainboard/google/rambi/variants/winky/devicetree.cb
index 9c25d1e..ed582ad 100644
--- a/src/mainboard/google/rambi/variants/winky/devicetree.cb
+++ b/src/mainboard/google/rambi/variants/winky/devicetree.cb
@@ -75,7 +75,7 @@
device pci 18.5 off end # I2C5
device pci 18.6 off end # I2C6
device pci 18.7 off end # I2C7
- device pci 1a.0 on end # TXE
+ device pci 1a.0 off end # TXE
device pci 1b.0 on end # HDA
device pci 1c.0 on end # PCIE_PORT1
device pci 1c.1 on end # PCIE_PORT2
--
To view, visit https://review.coreboot.org/c/coreboot/+/30235
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idaa152e15106b826fd5aa787090acd45719f4228
Gerrit-Change-Number: 30235
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181215/78613e48/attachment-0001.html>
More information about the coreboot-gerrit
mailing list