<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30235">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/rambi: disable TXE in devicetree for all variants<br><br>The TXE PCI device serves no function under Linux, and doesn't<br>work properly under Windows, so disable/hide it from the OS.<br><br>Test: Boot Windows 10 on google/squawks, verify TXE not visible<br>under Device Manager.<br><br>Change-Id: Idaa152e15106b826fd5aa787090acd45719f4228<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/rambi/variants/banjo/devicetree.cb<br>M src/mainboard/google/rambi/variants/candy/devicetree.cb<br>M src/mainboard/google/rambi/variants/clapper/devicetree.cb<br>M src/mainboard/google/rambi/variants/enguarde/devicetree.cb<br>M src/mainboard/google/rambi/variants/glimmer/devicetree.cb<br>M src/mainboard/google/rambi/variants/gnawty/devicetree.cb<br>M src/mainboard/google/rambi/variants/heli/devicetree.cb<br>M src/mainboard/google/rambi/variants/kip/devicetree.cb<br>M src/mainboard/google/rambi/variants/ninja/devicetree.cb<br>M src/mainboard/google/rambi/variants/orco/devicetree.cb<br>M src/mainboard/google/rambi/variants/quawks/devicetree.cb<br>M src/mainboard/google/rambi/variants/rambi/devicetree.cb<br>M src/mainboard/google/rambi/variants/squawks/devicetree.cb<br>M src/mainboard/google/rambi/variants/sumo/devicetree.cb<br>M src/mainboard/google/rambi/variants/swanky/devicetree.cb<br>M src/mainboard/google/rambi/variants/winky/devicetree.cb<br>16 files changed, 16 insertions(+), 16 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/30235/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/rambi/variants/banjo/devicetree.cb b/src/mainboard/google/rambi/variants/banjo/devicetree.cb</span><br><span>index acfb271..55d9873 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/banjo/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/banjo/devicetree.cb</span><br><span>@@ -74,7 +74,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 off end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 off end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/candy/devicetree.cb b/src/mainboard/google/rambi/variants/candy/devicetree.cb</span><br><span>index e4a39e9..e048361 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/candy/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/candy/devicetree.cb</span><br><span>@@ -75,7 +75,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 on end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 off end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/clapper/devicetree.cb b/src/mainboard/google/rambi/variants/clapper/devicetree.cb</span><br><span>index 497a0b1..1e50e53 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/clapper/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/clapper/devicetree.cb</span><br><span>@@ -62,7 +62,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 on end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 off end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/enguarde/devicetree.cb b/src/mainboard/google/rambi/variants/enguarde/devicetree.cb</span><br><span>index 3b00bb7..0db28d5 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/enguarde/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/enguarde/devicetree.cb</span><br><span>@@ -74,7 +74,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 off end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/glimmer/devicetree.cb b/src/mainboard/google/rambi/variants/glimmer/devicetree.cb</span><br><span>index db26366..5e7d646 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/glimmer/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/glimmer/devicetree.cb</span><br><span>@@ -71,7 +71,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 on end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/gnawty/devicetree.cb b/src/mainboard/google/rambi/variants/gnawty/devicetree.cb</span><br><span>index 30320cc..3559d99 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/gnawty/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/gnawty/devicetree.cb</span><br><span>@@ -74,7 +74,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 off end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/heli/devicetree.cb b/src/mainboard/google/rambi/variants/heli/devicetree.cb</span><br><span>index c3ec601..d6536c3 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/heli/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/heli/devicetree.cb</span><br><span>@@ -75,7 +75,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 off end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/kip/devicetree.cb b/src/mainboard/google/rambi/variants/kip/devicetree.cb</span><br><span>index 5bb99f0..24facb3 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/kip/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/kip/devicetree.cb</span><br><span>@@ -74,7 +74,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 off end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/ninja/devicetree.cb b/src/mainboard/google/rambi/variants/ninja/devicetree.cb</span><br><span>index c983681..b9e09e0 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/ninja/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/ninja/devicetree.cb</span><br><span>@@ -75,7 +75,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 off end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 off end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/orco/devicetree.cb b/src/mainboard/google/rambi/variants/orco/devicetree.cb</span><br><span>index 63b6097..c612336 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/orco/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/orco/devicetree.cb</span><br><span>@@ -74,7 +74,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 off end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/quawks/devicetree.cb b/src/mainboard/google/rambi/variants/quawks/devicetree.cb</span><br><span>index 0e1f789..ee0f38d 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/quawks/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/quawks/devicetree.cb</span><br><span>@@ -71,7 +71,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 off end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/rambi/devicetree.cb b/src/mainboard/google/rambi/variants/rambi/devicetree.cb</span><br><span>index a24bd33..0fb7f14 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/rambi/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/rambi/devicetree.cb</span><br><span>@@ -75,7 +75,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 on end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/squawks/devicetree.cb b/src/mainboard/google/rambi/variants/squawks/devicetree.cb</span><br><span>index ae4bfe5..4ed27be 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/squawks/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/squawks/devicetree.cb</span><br><span>@@ -71,7 +71,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 off end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/sumo/devicetree.cb b/src/mainboard/google/rambi/variants/sumo/devicetree.cb</span><br><span>index f354815..8f093c6 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/sumo/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/sumo/devicetree.cb</span><br><span>@@ -75,7 +75,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 on end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 off end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/swanky/devicetree.cb b/src/mainboard/google/rambi/variants/swanky/devicetree.cb</span><br><span>index d591e3f..57f8910 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/swanky/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/swanky/devicetree.cb</span><br><span>@@ -74,7 +74,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 off end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span>diff --git a/src/mainboard/google/rambi/variants/winky/devicetree.cb b/src/mainboard/google/rambi/variants/winky/devicetree.cb</span><br><span>index 9c25d1e..ed582ad 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/winky/devicetree.cb</span><br><span>+++ b/src/mainboard/google/rambi/variants/winky/devicetree.cb</span><br><span>@@ -75,7 +75,7 @@</span><br><span> device pci 18.5 off end # I2C5</span><br><span> device pci 18.6 off end # I2C6</span><br><span> device pci 18.7 off end # I2C7</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1a.0 on end # TXE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1a.0 off end # TXE</span><br><span> device pci 1b.0 on end # HDA</span><br><span> device pci 1c.0 on end # PCIE_PORT1</span><br><span> device pci 1c.1 on end # PCIE_PORT2</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30235">change 30235</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30235"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idaa152e15106b826fd5aa787090acd45719f4228 </div>
<div style="display:none"> Gerrit-Change-Number: 30235 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>