[coreboot-gerrit] Change in ...coreboot[master]: Work in progress: Early eMMC phase 1 - programming bridge

[Richard Spiegel (Code Review)]

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30214


Change subject: Work in progress: Early eMMC phase 1 - programming bridge
......................................................................

Work in progress: Early eMMC phase 1 - programming bridge

Global objective: Early ready of eMMC by sending "reset all".

This phase objective: Create bridge driver to be used by phase 2.

BUG=b:118680303
TEST=

Change-Id: I6261e5cbb16932282a98d937657e30bdcead8d6b
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/drivers/generic/temp_pcie_bridge/bridge_ram.c
M src/drivers/generic/temp_pcie_bridge/bridge_rom.c
M src/include/device/temp_bridge.h
3 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/30214/1

diff --git a/src/drivers/generic/temp_pcie_bridge/bridge_ram.c b/src/drivers/generic/temp_pcie_bridge/bridge_ram.c
index 753b31b..659e5af 100644
--- a/src/drivers/generic/temp_pcie_bridge/bridge_ram.c
+++ b/src/drivers/generic/temp_pcie_bridge/bridge_ram.c
@@ -27,7 +27,7 @@
 	return *(uint32_t *)PADDR(dev, reg);
 }
 
-int get_bases(DEVTREE_CONST struct device * bridge,
+int get_bases(DEVTREE_CONST struct device *bridge,
 	      struct device_addresses *params)
 {
 	uint32_t value;
diff --git a/src/drivers/generic/temp_pcie_bridge/bridge_rom.c b/src/drivers/generic/temp_pcie_bridge/bridge_rom.c
index 2a34b53..5e63b1f 100644
--- a/src/drivers/generic/temp_pcie_bridge/bridge_rom.c
+++ b/src/drivers/generic/temp_pcie_bridge/bridge_rom.c
@@ -43,7 +43,7 @@
 		value |= 1;
 		command |= PCI_COMMAND_IO;
 	}
-	pci_write_config32(dev, TEMP_BASE(number),value);
+	pci_write_config32(dev, TEMP_BASE(number), value);
 	command |= PCI_COMMAND_MASTER;
 	pci_write_config8(dev, PCI_COMMAND, command);
 	return status;
diff --git a/src/include/device/temp_bridge.h b/src/include/device/temp_bridge.h
index c457c7a..52a19f5 100644
--- a/src/include/device/temp_bridge.h
+++ b/src/include/device/temp_bridge.h
@@ -48,6 +48,6 @@
 
 int set_bases(pci_devfn_t bridge, struct device_addresses *params);
 int release_bases(pci_devfn_t bridge);
-int get_bases(DEVTREE_CONST struct device * bridge,
+int get_bases(DEVTREE_CONST struct device *bridge,
 	      struct device_addresses *params);
 #endif

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30214
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6261e5cbb16932282a98d937657e30bdcead8d6b
Gerrit-Change-Number: 30214
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181213/e6ed9ad4/attachment.html>