<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30214">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Work in progress: Early eMMC phase 1 - programming bridge<br><br>Global objective: Early ready of eMMC by sending "reset all".<br><br>This phase objective: Create bridge driver to be used by phase 2.<br><br>BUG=b:118680303<br>TEST=<br><br>Change-Id: I6261e5cbb16932282a98d937657e30bdcead8d6b<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/drivers/generic/temp_pcie_bridge/bridge_ram.c<br>M src/drivers/generic/temp_pcie_bridge/bridge_rom.c<br>M src/include/device/temp_bridge.h<br>3 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/30214/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/generic/temp_pcie_bridge/bridge_ram.c b/src/drivers/generic/temp_pcie_bridge/bridge_ram.c</span><br><span>index 753b31b..659e5af 100644</span><br><span>--- a/src/drivers/generic/temp_pcie_bridge/bridge_ram.c</span><br><span>+++ b/src/drivers/generic/temp_pcie_bridge/bridge_ram.c</span><br><span>@@ -27,7 +27,7 @@</span><br><span>         return *(uint32_t *)PADDR(dev, reg);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int get_bases(DEVTREE_CONST struct device * bridge,</span><br><span style="color: hsl(120, 100%, 40%);">+int get_bases(DEVTREE_CONST struct device *bridge,</span><br><span>               struct device_addresses *params)</span><br><span> {</span><br><span>  uint32_t value;</span><br><span>diff --git a/src/drivers/generic/temp_pcie_bridge/bridge_rom.c b/src/drivers/generic/temp_pcie_bridge/bridge_rom.c</span><br><span>index 2a34b53..5e63b1f 100644</span><br><span>--- a/src/drivers/generic/temp_pcie_bridge/bridge_rom.c</span><br><span>+++ b/src/drivers/generic/temp_pcie_bridge/bridge_rom.c</span><br><span>@@ -43,7 +43,7 @@</span><br><span>                 value |= 1;</span><br><span>          command |= PCI_COMMAND_IO;</span><br><span>   }</span><br><span style="color: hsl(0, 100%, 40%);">-       pci_write_config32(dev, TEMP_BASE(number),value);</span><br><span style="color: hsl(120, 100%, 40%);">+     pci_write_config32(dev, TEMP_BASE(number), value);</span><br><span>   command |= PCI_COMMAND_MASTER;</span><br><span>       pci_write_config8(dev, PCI_COMMAND, command);</span><br><span>        return status;</span><br><span>diff --git a/src/include/device/temp_bridge.h b/src/include/device/temp_bridge.h</span><br><span>index c457c7a..52a19f5 100644</span><br><span>--- a/src/include/device/temp_bridge.h</span><br><span>+++ b/src/include/device/temp_bridge.h</span><br><span>@@ -48,6 +48,6 @@</span><br><span> </span><br><span> int set_bases(pci_devfn_t bridge, struct device_addresses *params);</span><br><span> int release_bases(pci_devfn_t bridge);</span><br><span style="color: hsl(0, 100%, 40%);">-int get_bases(DEVTREE_CONST struct device * bridge,</span><br><span style="color: hsl(120, 100%, 40%);">+int get_bases(DEVTREE_CONST struct device *bridge,</span><br><span>        struct device_addresses *params);</span><br><span> #endif</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30214">change 30214</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30214"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6261e5cbb16932282a98d937657e30bdcead8d6b </div>
<div style="display:none"> Gerrit-Change-Number: 30214 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>