[coreboot-gerrit] Change in ...coreboot[master]: lenovo/h8, thinkpads: Re-do USB Always On
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Wed Dec 5 16:17:33 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29565 )
Change subject: lenovo/h8,thinkpads: Re-do USB Always On
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/29565/5/src/ec/lenovo/h8/h8.c
File src/ec/lenovo/h8/h8.c:
https://review.coreboot.org/#/c/29565/5/src/ec/lenovo/h8/h8.c@138
PS5, Line 138: val &= ~(H8_USB_ALWAYS_ON_ENABLE | H8_USB_ALWAYS_ON_AC_ONLY); // Clear bits 0,2,3
line over 80 characters
https://review.coreboot.org/#/c/29565/5/src/ec/lenovo/h8/h8.c@151
PS5, Line 151: val |= (H8_USB_ALWAYS_ON_ENABLE | H8_USB_ALWAYS_ON_AC_ONLY); // Set bits 0,2,3
line over 80 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/29565
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a
Gerrit-Change-Number: 29565
Gerrit-PatchSet: 5
Gerrit-Owner: Nathaniel Roach <nroach44 at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nathaniel Roach <nroach44 at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 05 Dec 2018 15:17:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181205/a2f75256/attachment.html>
More information about the coreboot-gerrit
mailing list