[coreboot-gerrit] Change in ...coreboot[master]: lenovo/h8, thinkpads: Re-do USB Always On

[Peter Lemenkov (Code Review)]

Peter Lemenkov has uploaded a new patch set (#5) to the change originally created by Nathaniel Roach. ( https://review.coreboot.org/c/coreboot/+/29565 )

Change subject: lenovo/h8,thinkpads: Re-do USB Always On
......................................................................

lenovo/h8,thinkpads: Re-do USB Always On

Re-write the UAO handling code as it had stopped working (#171)
  (the flag was not getting read from the RTC properly in SMM)

Remove the SMM code as it's not needed (but EC flag won't be set
  upon entering S3 now)
Set the EC flags on boot the same way other flags are set
Document bitwise operators for clarity
Propagate changes to other Thinkpads
  (updated X201 to have 2 bits for the flag as it only had 1)

Per Nicola Corna's previous commits, 0x0d is set for "AC only"
  "AC only" does exhibit different behaviour - the USB port is
  turned on a few seconds after entering S3, rather than < 1 sec,
  regardless of AC status

Tested on X220

Change-Id: If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a
Signed-off-by: Nathaniel Roach <nroach44 at gmail.com>
---
M src/ec/lenovo/h8/Makefile.inc
M src/ec/lenovo/h8/h8.c
M src/ec/lenovo/h8/h8.h
D src/ec/lenovo/h8/smm.c
M src/mainboard/lenovo/l520/smihandler.c
M src/mainboard/lenovo/t420/smihandler.c
M src/mainboard/lenovo/t420s/smihandler.c
M src/mainboard/lenovo/t430/smihandler.c
M src/mainboard/lenovo/t430s/smihandler.c
M src/mainboard/lenovo/t520/smihandler.c
M src/mainboard/lenovo/t530/smihandler.c
M src/mainboard/lenovo/x201/cmos.layout
M src/mainboard/lenovo/x201/smihandler.c
M src/mainboard/lenovo/x220/cmos.layout
M src/mainboard/lenovo/x220/smihandler.c
M src/mainboard/lenovo/x230/smihandler.c
16 files changed, 39 insertions(+), 72 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/29565/5
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29565
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a
Gerrit-Change-Number: 29565
Gerrit-PatchSet: 5
Gerrit-Owner: Nathaniel Roach <nroach44 at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181205/ed6529f1/attachment.html>