[coreboot-gerrit] Change in ...coreboot[master]: sb/intel: Fix pointer casts

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29875 )

Change subject: sb/intel: Fix pointer casts
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/29875/2/src/southbridge/intel/i82801ix/lpc.c 
File src/southbridge/intel/i82801ix/lpc.c:

https://review.coreboot.org/#/c/29875/2/src/southbridge/intel/i82801ix/lpc.c@556 
PS2, Line 556: acpigen_write_name_dword
> is this really writing out a 64bit pointer when compiled for 64bit? Or is this just enough to get th […]
NVSA is still 32bit.
The whole 64bit pointer to uint32_t doesn't matter that much, as all functions allocate memory below 4GiB and all code is loaded below 4GiB.

I thought about a macro that does the cast and asserts if the high bits are set. Is this what you had in mind ?

This is about getting basic support for x86_64 in qemu.
Running code or allocating memory beyond 4GiB on real hardware is still a long way.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29875
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfb3cacf25adfb4a242d38e4ea290fdc3929a684
Gerrit-Change-Number: 29875
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Wed, 05 Dec 2018 15:33:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <pgeorgi at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181205/9b086b47/attachment.html>