[coreboot-gerrit] Change in ...coreboot[master]: lenovo/h8, thinkpads: Re-do USB Always On

[Peter Lemenkov (Code Review)]

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29565 )

Change subject: lenovo/h8,thinkpads: Re-do USB Always On
......................................................................


Patch Set 5:

(4 comments)

Addressed all proposals above and rebased on top of current master.

https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c 
File src/ec/lenovo/h8/h8.c:

https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@136 
PS4, Line 136: e UA
> Pointless comment. […]
Done


https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@138 
PS4, Line 138: 		val &= ~(H8_USB_ALWAYS_ON_ENABLE | H8_USB_ALWAYS_ON_AC_ONLY); // Clear bits 0,2,3
> space required before the open brace '{'
Done


https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@138 
PS4, Line 138: 		val &= ~(H8_USB_ALWAYS_ON_ENABLE | H8_USB_ALWAYS_ON_AC_ONLY); // Clear bits 0,2,3
> space required before the open parenthesis '('
Done


https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@141 
PS4, Line 141: 
> Please don't use magic values
Done



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29565
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a
Gerrit-Change-Number: 29565
Gerrit-PatchSet: 5
Gerrit-Owner: Nathaniel Roach <nroach44 at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nathaniel Roach <nroach44 at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Comment-Date: Wed, 05 Dec 2018 15:18:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <siro at das-labor.org>
Comment-In-Reply-To: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181205/21c1f4f6/attachment.html>