[coreboot-gerrit] Change in ...coreboot[master]: mb/google/kahlee: the backlight doesn't be enabled if only update RW

[chris wang (Code Review)]

Hello Chris Wang,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/c/coreboot/+/30033

to review the following change.


Change subject: mb/google/kahlee: the backlight doesn't be enabled if only update RW
......................................................................

mb/google/kahlee: the backlight doesn't be enabled if only update RW

Since the initial for APU_EDP_BKLTEN_L was moved to early init.
If only update RW section, this GPIO will never be initialized.
To uses gpio_output() instead gpio_set(), then the GPIO will be
programmed in mainboard_smi_apmc().

Signed-off-by: Chris Wang <chris.wang at amd.corp-partner.google.com>
Change-Id: Ie6606d14bdc91a7f42bf235f64c3d23103cf5915
---
M src/mainboard/google/kahlee/OemCustomize.c
M src/mainboard/google/kahlee/smihandler.c
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/30033/1

diff --git a/src/mainboard/google/kahlee/OemCustomize.c b/src/mainboard/google/kahlee/OemCustomize.c
index fc8ff32..5b2221e 100644
--- a/src/mainboard/google/kahlee/OemCustomize.c
+++ b/src/mainboard/google/kahlee/OemCustomize.c
@@ -90,7 +90,7 @@
 		 * GPIO 133 - Backlight enable (active low)
 		 * Pass control of the backlight to the video BIOS
 		 */
-		gpio_set(GPIO_133, 0);
+		gpio_output(GPIO_133, 0);
 		printk(BIOS_INFO, "Change panel init timing\n");
 		params->LvdsPowerOnSeqVaryBlToBlon =
 			cfg->lvds_poseq_varybl_to_blon;
diff --git a/src/mainboard/google/kahlee/smihandler.c b/src/mainboard/google/kahlee/smihandler.c
index 83757a8..f5decda 100644
--- a/src/mainboard/google/kahlee/smihandler.c
+++ b/src/mainboard/google/kahlee/smihandler.c
@@ -43,7 +43,7 @@
 					MAINBOARD_EC_SMI_EVENTS);
 
 	/* Enable backlight - GPIO active low */
-	gpio_set(GPIO_133, 0);
+	gpio_output(GPIO_133, 0);
 
 	return 0;
 }

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30033
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6606d14bdc91a7f42bf235f64c3d23103cf5915
Gerrit-Change-Number: 30033
Gerrit-PatchSet: 1
Gerrit-Owner: chris wang <Chris.Wang at amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang at amd.corp-partner.google.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/41b91c7e/attachment-0001.html>