<p>chris wang would like Chris Wang to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30033">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/kahlee: the backlight doesn't be enabled if only update RW<br><br>Since the initial for APU_EDP_BKLTEN_L was moved to early init.<br>If only update RW section, this GPIO will never be initialized.<br>To uses gpio_output() instead gpio_set(), then the GPIO will be<br>programmed in mainboard_smi_apmc().<br><br>Signed-off-by: Chris Wang <chris.wang@amd.corp-partner.google.com><br>Change-Id: Ie6606d14bdc91a7f42bf235f64c3d23103cf5915<br>---<br>M src/mainboard/google/kahlee/OemCustomize.c<br>M src/mainboard/google/kahlee/smihandler.c<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/30033/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/OemCustomize.c b/src/mainboard/google/kahlee/OemCustomize.c</span><br><span>index fc8ff32..5b2221e 100644</span><br><span>--- a/src/mainboard/google/kahlee/OemCustomize.c</span><br><span>+++ b/src/mainboard/google/kahlee/OemCustomize.c</span><br><span>@@ -90,7 +90,7 @@</span><br><span>                * GPIO 133 - Backlight enable (active low)</span><br><span>           * Pass control of the backlight to the video BIOS</span><br><span>            */</span><br><span style="color: hsl(0, 100%, 40%);">-             gpio_set(GPIO_133, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+                gpio_output(GPIO_133, 0);</span><br><span>            printk(BIOS_INFO, "Change panel init timing\n");</span><br><span>           params->LvdsPowerOnSeqVaryBlToBlon =</span><br><span>                      cfg->lvds_poseq_varybl_to_blon;</span><br><span>diff --git a/src/mainboard/google/kahlee/smihandler.c b/src/mainboard/google/kahlee/smihandler.c</span><br><span>index 83757a8..f5decda 100644</span><br><span>--- a/src/mainboard/google/kahlee/smihandler.c</span><br><span>+++ b/src/mainboard/google/kahlee/smihandler.c</span><br><span>@@ -43,7 +43,7 @@</span><br><span>                                  MAINBOARD_EC_SMI_EVENTS);</span><br><span> </span><br><span>        /* Enable backlight - GPIO active low */</span><br><span style="color: hsl(0, 100%, 40%);">-        gpio_set(GPIO_133, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+        gpio_output(GPIO_133, 0);</span><br><span> </span><br><span>        return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30033">change 30033</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30033"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie6606d14bdc91a7f42bf235f64c3d23103cf5915 </div>
<div style="display:none"> Gerrit-Change-Number: 30033 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: chris wang <Chris.Wang@amd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Chris Wang <chris.wang@amd.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>