[coreboot-gerrit] Change in ...coreboot[master]: mb/google/kahlee: the backlight doesn't be enabled if only update RW

chris wang (Code Review) gerrit at coreboot.org
Tue Dec 4 14:12:43 CET 2018


Hello Chris Wang, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/30033

to look at the new patch set (#2).

Change subject: mb/google/kahlee: the backlight doesn't be enabled if only update RW
......................................................................

mb/google/kahlee: the backlight doesn't be enabled if only update RW

Since the initial for APU_EDP_BKLTEN_L was moved to early init.
If only update RW section, this GPIO will never be initialized.
To uses gpio_output() instead gpio_set(), then the GPIO will be
programmed in mainboard_smi_apmc().

BUG=b:120436919
TEST=Build/Verify on Careena and the backlight works normally.

Signed-off-by: Chris Wang <chris.wang at amd.corp-partner.google.com>
Change-Id: Ie6606d14bdc91a7f42bf235f64c3d23103cf5915
---
M src/mainboard/google/kahlee/OemCustomize.c
M src/mainboard/google/kahlee/smihandler.c
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/30033/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30033
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6606d14bdc91a7f42bf235f64c3d23103cf5915
Gerrit-Change-Number: 30033
Gerrit-PatchSet: 2
Gerrit-Owner: chris wang <Chris.Wang at amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang at amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/12571ae0/attachment.html>


More information about the coreboot-gerrit mailing list