[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/common: Create a common PCH finalise implementation
Tristan Corrick (Code Review)
gerrit at coreboot.org
Sat Dec 1 16:02:26 CET 2018
Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29977 )
Change subject: sb/intel/common: Create a common PCH finalise implementation
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/29977/3/src/southbridge/intel/common/finalize.c
File src/southbridge/intel/common/finalize.c:
https://review.coreboot.org/#/c/29977/3/src/southbridge/intel/common/finalize.c@75
PS3, Line 75: outb(POST_OS_BOOT, CONFIG_POST_IO_PORT);
I would have preferred to use `post_code(POST_OS_BOOT)`, but
console/post.c isn't linked in SMM. Is there a reason why? It does
compile when I set it up that way. Though, I suppose less code in
SMM is a good thing...
--
To view, visit https://review.coreboot.org/c/coreboot/+/29977
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I781082b1ed507b00815d1e85aec3e56ae5a4bef2
Gerrit-Change-Number: 29977
Gerrit-PatchSet: 3
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 01 Dec 2018 15:02:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/10c3f89a/attachment.html>
More information about the coreboot-gerrit
mailing list