[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/common: Create a common PCH finalise implementation

[Tristan Corrick (Code Review)]

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29977 )

Change subject: sb/intel/common: Create a common PCH finalise implementation
......................................................................


Patch Set 3:

(4 comments)

https://review.coreboot.org/#/c/29977/2/src/southbridge/intel/common/finalize.c 
File src/southbridge/intel/common/finalize.c:

https://review.coreboot.org/#/c/29977/2/src/southbridge/intel/common/finalize.c@a75 
PS2, Line 75: 	outb(POST_OS_BOOT, 0x80);
> The name is just misleading. You might want to change that instead […]
Done


https://review.coreboot.org/#/c/29977/2/src/southbridge/intel/common/finalize.c@61 
PS2, Line 61: 
> It was just called differently: PMIR (same location).
Okay, thanks.


https://review.coreboot.org/#/c/29977/2/src/southbridge/intel/common/finalize.c@62 
PS2, Line 62: 	pci_update_config32(lpc_dev, D31F0_ETR3, ~ETR3_CF9GR, ETR3_CF9LOCK);
            : 
            : 	if (IS_ENABLED(CONFIG_SOUTHBRID
> It's HSW only. […]
Done


https://review.coreboot.org/#/c/29977/2/src/southbridge/intel/common/pmutil.h 
File src/southbridge/intel/common/pmutil.h:

https://review.coreboot.org/#/c/29977/2/src/southbridge/intel/common/pmutil.h@25 
PS2, Line 25: F
> F
Done



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29977
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I781082b1ed507b00815d1e85aec3e56ae5a4bef2
Gerrit-Change-Number: 29977
Gerrit-PatchSet: 3
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 01 Dec 2018 14:59:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tristan Corrick <tristan at corrick.kiwi>
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/d449d2bd/attachment.html>