[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/common: Create a common PCH finalise implementation

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29977 )

Change subject: sb/intel/common: Create a common PCH finalise implementation
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/29977/3/src/southbridge/intel/common/finalize.c 
File src/southbridge/intel/common/finalize.c:

https://review.coreboot.org/#/c/29977/3/src/southbridge/intel/common/finalize.c@75 
PS3, Line 75: outb(POST_OS_BOOT, CONFIG_POST_IO_PORT);
> I would have preferred to use `post_code(POST_OS_BOOT)`, but […]
Maybe enable it in a follow up. If you do, also test that it compiles
with CONFIG_CONSOLE_POST and CONFIG_CMOS_POST.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29977
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I781082b1ed507b00815d1e85aec3e56ae5a4bef2
Gerrit-Change-Number: 29977
Gerrit-PatchSet: 3
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 01 Dec 2018 15:16:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/9b5b16e2/attachment.html>