[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/lynxpoint: Ensure the finalise handler is called

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29976 )

Change subject: sb/intel/lynxpoint: Ensure the finalise handler is called
......................................................................


Patch Set 1:

(1 comment)

Patrick G., not sure if anybody @google still cares, but it seems like
Lynx Point was missing the finalize trigger on the resume path all the
time.

https://review.coreboot.org/#/c/29976/1/src/southbridge/intel/lynxpoint/lpc.c 
File src/southbridge/intel/lynxpoint/lpc.c:

https://review.coreboot.org/#/c/29976/1/src/southbridge/intel/lynxpoint/lpc.c@972 
PS1, Line 972: IS_ENABLED(CONFIG_HAVE_SMI_HANDLER)
Should be selected by lynxpoint/Kconfig (instead of every single
board. And no need to check here, then.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29976
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9766a8dcbcb38420e937c810d252fef071851e92
Gerrit-Change-Number: 29976
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Sat, 01 Dec 2018 13:48:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/09f00a5b/attachment.html>