[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/lynxpoint: Ensure the finalise handler is called

Tristan Corrick (Code Review) gerrit at coreboot.org
Sat Dec 1 15:52:38 CET 2018


Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/29976

to look at the new patch set (#2).

Change subject: sb/intel/lynxpoint: Ensure the finalise handler is called
......................................................................

sb/intel/lynxpoint: Ensure the finalise handler is called

The finalise handler is not called during S3 resume when using the
`BS_PAYLOAD_BOOT` approach. So, adopt the `lpc_final` approach used by
bd82x6x and others.

Tested on an ASRock H81M-HDS. The finalise handler is now called on
the normal boot path, and during S3 resume.

Change-Id: I9766a8dcbcb38420e937c810d252fef071851e92
Signed-off-by: Tristan Corrick <tristan at corrick.kiwi>
---
M src/southbridge/intel/lynxpoint/lpc.c
M src/southbridge/intel/lynxpoint/smi.c
2 files changed, 6 insertions(+), 14 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/29976/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29976
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9766a8dcbcb38420e937c810d252fef071851e92
Gerrit-Change-Number: 29976
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/8b6b522a/attachment.html>


More information about the coreboot-gerrit mailing list