[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29651 )

Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID
......................................................................


Patch Set 5:

> > Is this just setting subsystem ids of a PCI device? These should
 > be
 > > set in the devicetree and no blob needed.
 > >
 > > If yes, this seems backwards. Shouldn't we set the id of the PCI
 > > device first and when configuring the codec take the id of the
 > PCI
 > > device?
 > 
 > From https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/pci/hda/patch_realtek.c?h=v4.20-rc4,
 > line 651, we can see kernel driver is comparing the ssid with pci
 > and verb.
 > 
 > ass = codec->core.subsystem_id & 0xffff;
 > if (codec->bus->pci &&
 > ass != codec->bus->pci->subsystem_device && (ass & 1))
 > goto do_sku;
 > 
 > I believe the ssid of detail codec is fixed, then we have to modify
 > BUS ssid to match with it. I have similar concern earlier in 29490.

Sorry I have make same comment more than once, seems something wrong with my browser.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488
Gerrit-Change-Number: 29651
Gerrit-PatchSet: 5
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Jairaj Arava <jairaj.arava at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Duncan Laurie <dlaurie at chromium.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Sat, 01 Dec 2018 00:21:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/00c16c6b/attachment.html>