[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID

Lijian Zhao (Code Review) gerrit at coreboot.org
Sat Dec 1 01:20:29 CET 2018


Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29651 )

Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID
......................................................................


Patch Set 5:

> Is this just setting subsystem ids of a PCI device? These should be
 > set in the devicetree and no blob needed.
 > 
 > If yes, this seems backwards. Shouldn't we set the id of the PCI
 > device first and when configuring the codec take the id of the PCI
 > device?

From https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/sound/pci/hda/patch_realtek.c?h=v4.19.5, I can see the codec driver is comparing ssid in codec and pci bus ssid. Since the codec SSID is fixed with sku, then I believe we can only change pci ssid to match with that.

Why we need to go through FSP but not in device tree had been discussed in 29490.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488
Gerrit-Change-Number: 29651
Gerrit-PatchSet: 5
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Jairaj Arava <jairaj.arava at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Duncan Laurie <dlaurie at chromium.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Sat, 01 Dec 2018 00:20:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/57ca9105/attachment.html>


More information about the coreboot-gerrit mailing list