<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Is this just setting subsystem ids of a PCI device? These should<br>be<br>set in the devicetree and no blob needed.<br>> If yes, this seems backwards. Shouldn't we set the id of the PCI<br>device first and when configuring the codec take the id of the<br>PCI<br>device?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">From https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/pci/hda/patch_realtek.c?h=v4.20-rc4,<br>line 651, we can see kernel driver is comparing the ssid with pci<br>and verb.</p><p style="white-space: pre-wrap; word-wrap: break-word;">ass = codec->core.subsystem_id & 0xffff;<br>if (codec->bus->pci &&<br>ass != codec->bus->pci->subsystem_device && (ass & 1))<br>goto do_sku;</p><p style="white-space: pre-wrap; word-wrap: break-word;">I believe the ssid of detail codec is fixed, then we have to modify<br>BUS ssid to match with it. I have similar concern earlier in 29490.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Sorry I have make same comment more than once, seems something wrong with my browser.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29651">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29651">change 29651</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29651"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 </div>
<div style="display:none"> Gerrit-Change-Number: 29651 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jairaj Arava <jairaj.arava@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-CC: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 01 Dec 2018 00:21:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>