[coreboot-gerrit] Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28380 )

Change subject: [WIP] Nvidia Optimus support for ThinkPads
......................................................................


Patch Set 2:

(2 comments)

Good job!
I already fixed _ROM a few times...
Time to add tests to FWTS.

https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layout
File src/mainboard/lenovo/t430/cmos.layout:

https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layout@131
PS2, Line 131: Graphics
Unrelated to optimus as you can use two GPUs even without it. Please add it in a separate commit.


https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430s/Kconfig
File src/mainboard/lenovo/t430s/Kconfig:

https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430s/Kconfig@26
PS2, Line 26: DRIVERS_LENOVO_HYBRID_GRAPHICS
T430s doesn't have hybrid graphics, as there's no mux at the lvds panel. You could add a CMOS option to enable/disable the dGPU instead. Dynamic power switching using Optimus is possible here too ofc.



-- 
To view, visit https://review.coreboot.org/28380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5
Gerrit-Change-Number: 28380
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 29 Aug 2018 06:26:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180829/fe8d1db9/attachment.html>