<p style="white-space: pre-wrap; word-wrap: break-word;">Good job!<br>I already fixed _ROM a few times...<br>Time to add tests to FWTS.</p><p><a href="https://review.coreboot.org/28380">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layout">File src/mainboard/lenovo/t430/cmos.layout:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layout@131">Patch Set #2, Line 131:</a> <code style="font-family:monospace,monospace">Graphics</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unrelated to optimus as you can use two GPUs even without it. Please add it in a separate commit.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430s/Kconfig">File src/mainboard/lenovo/t430s/Kconfig:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430s/Kconfig@26">Patch Set #2, Line 26:</a> <code style="font-family:monospace,monospace">DRIVERS_LENOVO_HYBRID_GRAPHICS</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">T430s doesn't have hybrid graphics, as there's no mux at the lvds panel. You could add a CMOS option to enable/disable the dGPU instead. Dynamic power switching using Optimus is possible here too ofc.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28380">change 28380</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28380"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5 </div>
<div style="display:none"> Gerrit-Change-Number: 28380 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 29 Aug 2018 06:26:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>