[coreboot-gerrit] Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads

[Evgeny Zinoviev (Code Review)]

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28380 )

Change subject: [WIP] Nvidia Optimus support for ThinkPads
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layout
File src/mainboard/lenovo/t430/cmos.layout:

https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layout@131
PS2, Line 131: Graphics
> Unrelated to optimus as you can use two GPUs even without it. Please add it in a separate commit.
Do you think I should move has_thinker1 changes in devicetrees to a separate commit too?

By the way I'm not sure "has_thinker1" is correct, as they seemingly don't have thinker1 (according to schematics), but dGPU registers still work and it seems it's the only usage of has_thinker1 in coreboot.



-- 
To view, visit https://review.coreboot.org/28380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5
Gerrit-Change-Number: 28380
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 29 Aug 2018 09:38:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180829/b7f14583/attachment.html>