[coreboot-gerrit] Change in coreboot[master]: commonlib/timestamp_serialized: Add AGESA timestamp descriptions

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/28271 )

Change subject: commonlib/timestamp_serialized: Add AGESA timestamp descriptions
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/28271/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28271/1//COMMIT_MSG@8
PS1, Line 8: 
Add an explanation of why this is needed?


https://review.coreboot.org/#/c/28271/1/src/commonlib/include/commonlib/timestamp_serialized.h
File src/commonlib/include/commonlib/timestamp_serialized.h:

https://review.coreboot.org/#/c/28271/1/src/commonlib/include/commonlib/timestamp_serialized.h@263
PS1, Line 263: 0x1100
Why magic numbers? All previous were part of a enum. You could use a enum here too, or you could use #define (more time consuming). As for names, TS_AGESA_xxx



-- 
To view, visit https://review.coreboot.org/28271
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47112bdf9601bcd51b7ff7f84d948d5bb6537cf
Gerrit-Change-Number: 28271
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 16:07:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180822/186115fe/attachment.html>