<p><a href="https://review.coreboot.org/28271">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28271/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28271/1//COMMIT_MSG@8">Patch Set #1, Line 8:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add an explanation of why this is needed?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28271/1/src/commonlib/include/commonlib/timestamp_serialized.h">File src/commonlib/include/commonlib/timestamp_serialized.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28271/1/src/commonlib/include/commonlib/timestamp_serialized.h@263">Patch Set #1, Line 263:</a> <code style="font-family:monospace,monospace">0x1100</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why magic numbers? All previous were part of a enum. You could use a enum here too, or you could use #define (more time consuming). As for names, TS_AGESA_xxx</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28271">change 28271</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28271"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib47112bdf9601bcd51b7ff7f84d948d5bb6537cf </div>
<div style="display:none"> Gerrit-Change-Number: 28271 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 22 Aug 2018 16:07:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>